end() crashes when the last component of an entity has been removed #2

New issue

Closed

opened 2023-04-16 18:52:32 +02:00 by 0xEAB · 7 comments

0xEAB commented

2023-04-16 18:52:32 +02:00

(Migrated from gitlab.com)

gEntityManager.end() crashes when the last component of an entity is to be removed.

onUpdate(EntitiesData data) {
    // […]

    gEntityManager.removeComponents!Component2(entityID);
    gEntityManager.removeComponents!Component1(entityID);
    // no more components left for entity with ID `entityID`
}

core.exception.ArrayIndexError@…/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d(1871): index [18446744073709551615] is out of bounds for array of length 0
----------------
…/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:1871
…/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:3487
…/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:2206
…/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:2838
…/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:3106
…/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:3146
my-code/code.d:100  ← `gEntityManager.end();`

`gEntityManager.end()` crashes when the last component of an entity is to be removed. ```d onUpdate(EntitiesData data) { // […] gEntityManager.removeComponents!Component2(entityID); gEntityManager.removeComponents!Component1(entityID); // no more components left for entity with ID `entityID` } ``` ``` core.exception.ArrayIndexError@…/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d(1871): index [18446744073709551615] is out of bounds for array of length 0 ---------------- …/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:1871 …/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:3487 …/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:2206 …/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:2838 …/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:3106 …/bubel-ecs-0.1.1/bubel-ecs/source/bubel/ecs/manager.d:3146 my-code/code.d:100 ← `gEntityManager.end();` ```

Mergul commented

2023-04-23 21:45:51 +02:00

(Migrated from gitlab.com)

Interesting. If I understand correctly you just removed all components from an entity?
I haven't thought about having entities without components. I would try to look at that tomorrow. It shouldn't be very hard to implement.

Interesting. If I understand correctly you just removed all components from an entity? I haven't thought about having entities without components. I would try to look at that tomorrow. It shouldn't be very hard to implement.

Mergul commented

2023-04-24 21:11:51 +02:00

(Migrated from gitlab.com)

assigned to @Mergul